Skip to content

Add Array Type Hints - Repositories

Priority: 🟡 P2 - MEDIUM Status: Planning Related Analysis: phpstan-rector-analysis-overview.md

Problem Statement

~40 PHPStan errors in repository classes for missing array value types (subset of 294 total).

Impact

  • Repositories return query results as arrays
  • Type hints clarify what queries return
  • Improves query builder type safety

Scope

Repository layer:

  • src/Repository/
  • Query result arrays
  • Criteria arrays
  • Parameter arrays

Common Repository Patterns

Pattern 1: Query Results

/**
 * @return array<int, CoffeeBean>
 */
public function findByCriteria(array $criteria): array

Pattern 2: Criteria Arrays

/**
 * @param array<string, mixed> $criteria
 */
public function findByCriteria(array $criteria): array

Implementation Plan

Similar to entities/services, but repositories are typically simpler.

Estimated Effort: 4-6 hours